Viewing a single comment thread. View all comments

dreugeworst t1_it742kh wrote

I've previously had to recompile the cc library as it wasn't exporting all the symbols needed to use certain parts of the api. I couldn't find it at a glance, sorry if this was listed somewhere obvious, but does this repo expand the exports from the shared object / dll?

1

lennart-reiher-ika OP t1_it7d6sw wrote

Since we have not yet run into such issues, my guess would be that we currently do not do such expansion. Do you have a C++ snippet to test?

1

dreugeworst t1_it7lvwh wrote

We were having issues with using LoadSavedModel in combination with a SavedModelBundle. As the latter included a protobuf::map in the struct definition and protobuf symbols weren't exported, this caused us issues.

I just tried a minimal example and it worked. It has been 2 years since I came across this issue, so probably something has changed. Although I don't see the relevant symbols added to the version script, the .so file does export the symbols in question, perhaps I was compiling with -fvisibility=hidden on, or maybe this has been removed by the tf project.

Does your CMake support come from the tensorflow project? Bit disappointing to see there is still no tensorflow target. BTW, I think your example meant to use target_include_directories(foo PRIVATE ${TensorFlow_INCLUDE_DIRS})

1

lennart-reiher-ika OP t1_itk8f3h wrote

The TensorFlow target is installed by ourselves with a custom TensorFlowConfig.cmake, so no, unfortunately there is no official target.

Thanks for the hint!

1