I think it really depends on what you are looking for. If you have a lot of physical media or want to buy games on disc/used then its not going to be able to do that.

however, if you are fine with digital copies it's a great value.

The biggest advantage is that you can for about 10-15 a month get access to hundreds of games with game pass. That alone makes it a much more valuable experience.