I'd recommend getting a 1TB external hard drive to plug into the console as the storage can be quite limiting if you are downloading a lot of different games. I'm not actually sure what happens if you cancel the subscription, but I'll presume you just lose access to any games you've downloaded through it.

You lose access to any games you didn't buy outright if you cancel your sub. Personally, I only subscribe when I find enough games as part of the bundle that would cost more to buy individually than a one year subscription, and I rarely revisit games I've finished, so I don't mind the sub. I buy outright the games I intend to play for a very long time (usually Forza titles) or if they are discounted steeply enough to be worth my taking a chance.

The additional storage costs on the Series S make it a poor choice. The cost of 1TB of official additional storage added to the console makes it a better idea to simply buy the Series X which includes 1TB as standard.

At the end of the day, I always say buy the console that enables you to play the games you like. It's really hard for us random strangers on the internet to give you impartial advice.

Do you like RPGs? Playstation has a more compelling collection of those, e.g Uncharted, Ghost of Tsushima, Ratchet and Clank (to my taste).

The Xbox has the best driving sims/arcade racers in the Forza and Horizon series, and also Smart Delivery is a pretty good feature if you also game on a PC. Nice to be able to have your progress synced between PC and Console for the titles that support it.

There's a huge commonality in the titles across xbox and playstation too and Nintendo has a bunch of very fun, family friendly exclusive titles that make it a pretty good buy.