I think it definitely depends on each person and their usage. I upgrade every 4 years but I know some people who will hold onto phones that are practically begging to be replaced because "it still works". I don't think most people should be upgrading every year though, the improvements are too marginal to be worth the money.