No, not almost everyone should. People who have a particular short term goal they are saving up cash for should. Saving for a down payment on a house or something? I bonds are great.

All my current savings goals are either less than one year (emergency savings which I might need tomorrow, summer vacation), or very long term (retirement). Neither of those are suitable for I bonds.